Bids 3014/edit webhook dialog #593

marcel-bitfly · 2024-07-18T08:15:44Z

update of nuxt
update of depending packages
refactorings due to errors caused by updates
some BaseComponents (e.g. Forms)
mechanism to make sure only the topmost Dialog of nested Dialogs (Dialogs opening Dialogs) gets closed
implementing edit webhook dialog
add validation object and schema factory (to abstract yup library)

frontend/assets/css/prime.scss

marcel-bitfly · 2024-07-18T08:47:38Z

We have to come up with new formatting rules, as I had to remove the deprecated nuxt 2 eslint formating rules 🙃

We could

still use eslint for formatting
- e.g. eslint.stylistic
  - also see: https://eslint.nuxt.com/packages/module#eslint-stylistic
add prettier
- pro: no discussions necessary

(Also take into consideration: https://www.joshuakgoldberg.com/blog/configuring-eslint-prettier-and-typescript-together/#stop-using-eslint-for-formatting)

(nice to have, as we do not use a css utility framework : https://stylelint.io/)

thib-wien · 2024-07-18T09:51:48Z

👋🏻
My overall comments on your PR:

you did a useful and courageous work, thanks for updating,
maybe separate the update from your dialog boxes,
you created small components for a button, a form, an input, but they are quite empty. If they are not meant to grow, writing their code directly in the parent file would decrease the already huge amount of files that we have,
I do not like these silencers for es-lint, it looks like bad practice (it is not your fault). Maybe we could relax some rules if Alexander finds some of them annoying, and open a BIDS to refactor the code so that we do not need the remaining silencers.

cloudflare-workers-and-pages · 2024-07-23T13:30:31Z

Deploying beaconchain with Cloudflare Pages

Latest commit:	`22f52ba`
Status:	✅ Deploy successful!
Preview URL:	https://0c4cfa6b.beaconchain.pages.dev
Branch Preview URL:	https://bids-3014-edit-webhook-dialo.beaconchain.pages.dev

View logs

MauserBitfly

Quit some work you did there with all the eslint / types refactoring.

I like that you created some more base components.

The UI of the dialog already looks nice and works fine.

Left some comments for consideration / discussion ;-)

frontend/assets/css/colors.scss

frontend/components/bc/BcButton.vue

frontend/components/notifications/management/modal/NotificationsManagementModalWebhook.vue

frontend/components/dashboard/creation/DashboardCreationNetworkMask.vue

frontend/assets/css/colors.scss

frontend/components/bc/BcTooltip.vue

frontend/components/bc/form/BcFormRow.vue

MauserBitfly

Thanks for the updates.

Still might consider changing this

And please remove the new console.log ;-)

frontend/components/notifications/management/modal/NotificationsManagementModalWebhook.vue

frontend/components/bc/BcButton.vue

frontend/components/bc/BcTooltip.vue

frontend/components/bc/BcButton.vue

frontend/components/bc/input/BcInputError.vue

frontend/components/bc/form/BcFormRow.vue

frontend/components/bc/BcLink.vue

frontend/components/bc/BcTranslation.vue

frontend/components/bc/input/BcInputCheckbox.vue

frontend/components/bc/BcTranslation.vue

Due to the introduction of `nested css` sass had to change the be compliant. So there should not be `declerations` after `nested code` or the code should be wraped in '& {}' explicitly See: https://sass-lang.com/documentation/breaking-changes/mixed-decls/

Due to `typescript package updates` some imports had to by adapted.

Refactoring was necessary due to `nuxt/prefer-import-meta` eslint rule, due to an upate

Refactoring was necessary due to an upate

- due to conflicts the `newest and recommended eslint integration` was added - Locking `prime vue version` to `0.2.2` due to a `breaking change in styles`.

Might broke due to a `merge conflict`

Replace import of `yup schema builder` with the recomended version. See: https://vee-validate.logaretm.com/v4/guide/composition-api/getting-started/

Added undefined to `error description`

MauserBitfly

LGTM

Add `BaseComponents` like `Forms` and `Buttons` Add `autocomplete` for `translations` via `useTranslations()` Add `schema factory` and `validation object`to wrap `third party validation` See: BIDS-3014

Arrow functions have been called in `watch` before `initialization`

marcel-bitfly commented Jul 18, 2024

View reviewed changes

frontend/assets/css/prime.scss Show resolved Hide resolved

marcel-bitfly force-pushed the BIDS-3014/edit-webhook-dialog branch 6 times, most recently from 82712cc to 64f90c6 Compare July 23, 2024 13:30

marcel-bitfly force-pushed the BIDS-3014/edit-webhook-dialog branch 8 times, most recently from 4743f2d to 5a3ec02 Compare July 25, 2024 12:26

MauserBitfly reviewed Jul 25, 2024

View reviewed changes

marcel-bitfly force-pushed the BIDS-3014/edit-webhook-dialog branch 5 times, most recently from a2b6c60 to d53913f Compare July 30, 2024 09:25

marcel-bitfly commented Jul 30, 2024

View reviewed changes

frontend/components/dashboard/creation/DashboardCreationNetworkMask.vue Outdated Show resolved Hide resolved

marcel-bitfly force-pushed the BIDS-3014/edit-webhook-dialog branch 5 times, most recently from d5423df to 4edd96d Compare August 1, 2024 10:59

marcel-bitfly force-pushed the BIDS-3014/edit-webhook-dialog branch from 4edd96d to 86847ad Compare August 1, 2024 11:30

marcel-bitfly commented Aug 1, 2024

View reviewed changes

frontend/assets/css/colors.scss Show resolved Hide resolved

frontend/components/bc/BcTooltip.vue Show resolved Hide resolved

frontend/components/bc/form/BcFormRow.vue Show resolved Hide resolved

MauserBitfly reviewed Aug 1, 2024

View reviewed changes

marcel-bitfly force-pushed the BIDS-3014/edit-webhook-dialog branch 3 times, most recently from b6d1765 to fcb82ec Compare August 2, 2024 10:21

MauserBitfly reviewed Aug 5, 2024

View reviewed changes

MarcelBitfly added 9 commits August 5, 2024 11:15

Refactor 'type imports'

561ef35

Due to `typescript package updates` some imports had to by adapted.

Replace process.server with isServer util

b226eb9

Refactoring was necessary due to `nuxt/prefer-import-meta` eslint rule, due to an upate

Replace process.client with isClient util

7bbf6de

Refactoring was necessary due to `nuxt/prefer-import-meta` eslint rule, due to an upate

Fix linting errors

bd2b524

Refactoring was necessary due to an upate

Update nuxt and add new eslint module

71bb27e

- due to conflicts the `newest and recommended eslint integration` was added - Locking `prime vue version` to `0.2.2` due to a `breaking change in styles`.

Fix notifications dashboard search placeholder

7a5442f

Might broke due to a `merge conflict`

Update validation package for best compatibility

67307a7

Replace import of `yup schema builder` with the recomended version. See: https://vee-validate.logaretm.com/v4/guide/composition-api/getting-started/

Fix 'grouped error toasts`

0f2bc56

Added undefined to `error description`

marcel-bitfly force-pushed the BIDS-3014/edit-webhook-dialog branch from 9123f97 to 17ed892 Compare August 5, 2024 12:44

MauserBitfly approved these changes Aug 5, 2024

View reviewed changes

MarcelBitfly added 2 commits August 5, 2024 14:56

Add Edit Webhooks Modal on NotificationsManagementModal

071cbc5

Add `BaseComponents` like `Forms` and `Buttons` Add `autocomplete` for `translations` via `useTranslations()` Add `schema factory` and `validation object`to wrap `third party validation` See: BIDS-3014

fix(NotificationsManagementSubcriptionDialog): relocate code

22f52ba

Arrow functions have been called in `watch` before `initialization`

marcel-bitfly force-pushed the BIDS-3014/edit-webhook-dialog branch from 17ed892 to 22f52ba Compare August 5, 2024 12:58

marcel-bitfly merged commit e0d9c21 into staging Aug 5, 2024
2 checks passed

marcel-bitfly deleted the BIDS-3014/edit-webhook-dialog branch August 5, 2024 13:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bids 3014/edit webhook dialog #593

Bids 3014/edit webhook dialog #593

marcel-bitfly commented Jul 18, 2024 •

edited

Loading

marcel-bitfly commented Jul 18, 2024 •

edited

Loading

thib-wien commented Jul 18, 2024

cloudflare-workers-and-pages bot commented Jul 23, 2024 •

edited

Loading

MauserBitfly left a comment

MauserBitfly left a comment

MauserBitfly left a comment

Bids 3014/edit webhook dialog #593

Bids 3014/edit webhook dialog #593

Conversation

marcel-bitfly commented Jul 18, 2024 • edited Loading

marcel-bitfly commented Jul 18, 2024 • edited Loading

thib-wien commented Jul 18, 2024

cloudflare-workers-and-pages bot commented Jul 23, 2024 • edited Loading

Deploying beaconchain with Cloudflare Pages

MauserBitfly left a comment

Choose a reason for hiding this comment

MauserBitfly left a comment

Choose a reason for hiding this comment

MauserBitfly left a comment

Choose a reason for hiding this comment

marcel-bitfly commented Jul 18, 2024 •

edited

Loading

marcel-bitfly commented Jul 18, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Jul 23, 2024 •

edited

Loading