Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nobids/toggle bar #60

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Nobids/toggle bar #60

merged 10 commits into from
Mar 5, 2024

Conversation

MauserBitfly
Copy link
Contributor

New ToggleBar component - used in the slot viz for filtering. New Layout / Structure / Logic for slot viz Tooltip

Note:

  1. Switched back to mock data for slot viz (until the backend also updated)
  2. Change the api slot_viz.ts Interfaces according to new specs. Should be overwritten with the merged file from update slot viz struct to new design #59 (once this is finalized - hopefully w/o changes - and merged)

@MauserBitfly MauserBitfly requested a review from D13ce March 1, 2024 14:09
D13ce
D13ce suggested changes Mar 4, 2024
View reviewed changes
frontend/components/bc/toggle/BcToggleButton.vue Outdated Show resolved Hide resolved
frontend/i18n/en.json Outdated Show resolved Hide resolved
frontend/i18n/en.json Outdated Show resolved Hide resolved
frontend/nuxt.config.ts Outdated Show resolved Hide resolved
frontend/components/slot/viz/SlotVizTooltip.vue Show resolved Hide resolved
@MauserBitfly MauserBitfly requested a review from D13ce March 4, 2024 09:45
D13ce
D13ce reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good solution for the translation files. I found a minor bug. Please let me know if you think that this should be fixed.

frontend/utils/translation.ts Show resolved Hide resolved
D13ce
D13ce approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MauserBitfly MauserBitfly merged commit 21ea25b into main Mar 5, 2024
1 check passed
@MauserBitfly MauserBitfly deleted the NOBIDS/toggle-bar branch March 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buttaa Buttaa Buttaa left review comments

@D13ce D13ce D13ce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauserBitfly @Buttaa @D13ce