Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile App Authentication #602

Merged
merged 28 commits into from
Aug 7, 2024
Merged

Mobile App Authentication #602

merged 28 commits into from
Aug 7, 2024

Conversation

manuelsc
Copy link
Contributor

@manuelsc manuelsc commented Jul 22, 2024 •
edited
Loading

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 22, 2024 •
edited
Loading

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: d687384
Status: ✅  Deploy successful!
Preview URL: https://3dc6ec3e.beaconchain.pages.dev
Branch Preview URL: https://mobilev2.beaconchain.pages.dev

View logs

@manuelsc manuelsc requested a review from LuccaBitfly July 23, 2024 11:05
LuccaBitfly
LuccaBitfly requested changes Jul 30, 2024
View reviewed changes
backend/pkg/api/data_access/user.go Outdated Show resolved Hide resolved
backend/pkg/api/router.go Outdated Show resolved Hide resolved
backend/pkg/api/handlers/auth.go Outdated Show resolved Hide resolved
backend/pkg/api/handlers/auth.go Outdated Show resolved Hide resolved
backend/pkg/api/data_access/user.go Outdated Show resolved Hide resolved
backend/pkg/api/handlers/auth.go Show resolved Hide resolved
backend/pkg/api/router.go Outdated Show resolved Hide resolved
backend/pkg/api/handlers/backward_compat.go Outdated Show resolved Hide resolved
backend/pkg/commons/utils/user.go Outdated Show resolved Hide resolved
backend/pkg/api/handlers/auth.go Show resolved Hide resolved
@LuccaBitfly
Copy link
Contributor

LuccaBitfly commented Jul 30, 2024 •
edited
Loading

Couldn't test whether this works with the mobile app obviously, so I trust that you've done this. For FE or data access stuff you should prob get someone from the respective team to review the code.

@manuelsc manuelsc requested a review from LuccaBitfly July 30, 2024 12:21
LuccaBitfly
LuccaBitfly approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manuelsc manuelsc merged commit ea2c63a into staging Aug 7, 2024
2 checks passed
@sasha-bitfly sasha-bitfly deleted the mobilev2 branch January 9, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuccaBitfly LuccaBitfly LuccaBitfly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelsc @LuccaBitfly @remoterami