(BIDS 3226) API: Block Details v2 (Internal) #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remoterami
force-pushed
the
BIDS-3226/api-blocks
branch
from
2cc3f17 to
d2e2cd6
Compare
Deploying beaconchain with
|
| Latest commit: |
189f0be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8155019b.beaconchain.pages.dev |
| Branch Preview URL: | https://bids-3226-api-blocks.beaconchain.pages.dev |
remoterami
force-pushed
the
BIDS-3226/api-blocks
branch
from
d2e2cd6 to
c8f6185
Compare
LuccaBitfly
requested changes
Jul 30, 2024
LuccaBitfly
reviewed
Jul 30, 2024
LuccaBitfly
approved these changes
Jul 31, 2024
MauserBitfly
reviewed
Aug 1, 2024
| /** | ||
| * General | ||
| */ | ||
| block: number /* uint64 */; |
There was a problem hiding this comment.
Some properties overlap between the BlockOverview and the BlockExecutionPayload.
Wouldn't it be enough to have them just in the BlockExecutionPayload ?
There was a problem hiding this comment.
That was just done because of our approach to design the internal api closely tailored to the designs and keep the frontend as simple as possible. But you're right, that information is redundant and can be removed, see the new changes; I've kept the duplicates in the base BlockOverview though because BlockExecutionPayload is intended to be present for POS blocks only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.