-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add our
style changes to toast messages. BIDS-3206.
#650
Conversation
benji-bitfly
commented
Jul 31, 2024
- Add necessery new colors and variable to follow the figma design. BIDS-3206
UXUI approved ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, left some comments
frontend/assets/css/prime.scss
Outdated
.p-toast { | ||
opacity: 1; | ||
|
||
.p-toast-message { | ||
margin: 0 0 1rem 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please replace all rem values with px values. And maybe use our padding variables (where possible) for margin and padding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my comment was not clear enought, please update ALL rem values in the toast styles with px ;-)
Deploying beaconchain with Cloudflare Pages
|
@MauserBitfly thank you :) Adjusted code for the comments. |
…iables. BIDS-3206
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM