Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add our style changes to toast messages. BIDS-3206. #650

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

benji-bitfly
Copy link
Contributor

  • Add necessery new colors and variable to follow the figma design. BIDS-3206

Screenshot from 2024-07-31 10-16-29

@benji-bitfly
Copy link
Contributor Author

UXUI approved ✔️

Copy link
Contributor

@MauserBitfly MauserBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, left some comments

frontend/assets/css/colors.scss Show resolved Hide resolved
frontend/assets/css/colors.scss Outdated Show resolved Hide resolved
frontend/assets/css/colors.scss Outdated Show resolved Hide resolved
frontend/assets/css/fonts.scss Outdated Show resolved Hide resolved
.p-toast {
opacity: 1;

.p-toast-message {
margin: 0 0 1rem 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please replace all rem values with px values. And maybe use our padding variables (where possible) for margin and padding.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my comment was not clear enought, please update ALL rem values in the toast styles with px ;-)

frontend/assets/css/prime.scss Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Jul 31, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: d099d04
Status: ✅  Deploy successful!
Preview URL: https://ccf9a8eb.beaconchain.pages.dev
Branch Preview URL: https://bids-3206-apply-our-stylings.beaconchain.pages.dev

View logs

@benji-bitfly
Copy link
Contributor Author

@MauserBitfly thank you :) Adjusted code for the comments.

@D13ce D13ce requested a review from MauserBitfly July 31, 2024 11:14
Copy link
Contributor

@MauserBitfly MauserBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benji-bitfly benji-bitfly merged commit 25580d8 into staging Jul 31, 2024
2 checks passed
@benji-bitfly benji-bitfly deleted the BIDS-3206/Apply-our-stylings-to-toasts branch July 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants