Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bids 3184/restructure validator dashboard header #670

Merged

Conversation

MauserBitfly
Copy link
Contributor

This PR

  • changes the arrangement of the dashboard header and control rows.
    • changes the create new dashboard button to secondary
    • moves some buttons from the dashboard header to the control row
    • combines dashboard configuration buttons into one settings menu
    • changing the label of the Dashboard selections to Validators / Accounts instead of the selected name
    • adds the global Rocket Pool (RP) Switch to the settings - currently disabled in production.
  • creates a BcMenuBar component wrapping the Primevue Menubarto be used in the header and control row
    • changes the default style for the menu bar and uses the previous style only for highlighted menu bar items
  • uses the secondary button style for the content filter button

This PR:

  • does not change the logic when buttons are shown only where and how.

Copy link

cloudflare-workers-and-pages bot commented Aug 6, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 000fbdd
Status: ✅  Deploy successful!
Preview URL: https://f8f41247.beaconchain.pages.dev
Branch Preview URL: https://bids-3184-restructure-valida.beaconchain.pages.dev

View logs

Copy link
Contributor

@benji-bitfly benji-bitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@MauserBitfly MauserBitfly merged commit acdbb0a into staging Aug 7, 2024
2 checks passed
@MauserBitfly MauserBitfly deleted the BIDS-3184/restructure-validator-dashboard-header branch August 7, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants