Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(i18n): replace useI18n() with useTranslation() #672

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

marcel-bitfly
Copy link
Contributor

This will enable autocomplete for translations to improve dx. And wraps third party code for better maintainability.

See: BEDS-97 (personal Ticket)

Copy link

cloudflare-workers-and-pages bot commented Aug 6, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 092c4fe
Status: ✅  Deploy successful!
Preview URL: https://9b8638e7.beaconchain.pages.dev
Branch Preview URL: https://beds-97-replace-usei18n.beaconchain.pages.dev

View logs

@marcel-bitfly
Copy link
Contributor Author

example:
autocompletion

Copy link
Contributor

@MauserBitfly MauserBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This will enable `autocomplete` for `translations` to improve `dx`.
And wraps `third party` code for better `maintainability`.

See: BEDS-97
@marcel-bitfly marcel-bitfly force-pushed the BEDS-97/replace-useI18n branch from c717308 to 092c4fe Compare August 6, 2024 10:21
@marcel-bitfly marcel-bitfly merged commit e46a6fd into staging Aug 6, 2024
2 checks passed
@marcel-bitfly marcel-bitfly deleted the BEDS-97/replace-useI18n branch August 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants