style(eslint): add plugin perfectionist
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying beaconchain with
|
| Latest commit: |
ea6a6e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4c3ef7b.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-128-add-perfectionist-r.beaconchain.pages.dev |
marcel-bitfly
force-pushed
the
BEDS-128/add-perfectionist-rules
branch
2 times, most recently
from
e6ec426 to
7d72b3e
Compare
added 3 commits
August 9, 2024 10:00
…ments` See: BIDS-128
editor.formatOnSave has to be `false`, as we are not using a formatter, but a `linter for formatting`. This way we could only trigger `linting` only before merging stuff. Which would shorten our compute time. See: https://eslint.style/guide/faq#how-to-auto-format-on-save See: BEDS-128
marcel-bitfly
force-pushed
the
BEDS-128/add-perfectionist-rules
branch
from
7d72b3e to
51eb4a0
Compare
marcel-bitfly
commented
Aug 9, 2024
Comment on lines
+8
to
+10
| const { | ||
| currency, setCurrency, withLabel, | ||
| } = useCurrency() |
There was a problem hiding this comment.
fyi: should be like that, but atm could not get autofixed, as the rule:
https://eslint.style/rules/js/object-property-newline#object-property-newline
lacks a proper destructuring logic
Suggested change
| const { | |
| currency, setCurrency, withLabel, | |
| } = useCurrency() | |
| const { | |
| currency, | |
| setCurrency, | |
| withLabel, | |
| } = useCurrency() |
marcel-bitfly
force-pushed
the
BEDS-128/add-perfectionist-rules
branch
from
f729ee8 to
34a33dd
Compare
Putting items on new lines should make editing more `efficient` and make it easier to check for changes when reviewing See: BEDS-128
With sharing the same `delimiter` between `js` and `ts` `types` and `interfaces` could be copied to create an `object` See: BEDS-128
New feature in vue. Fewer code. See: BEDS-128
marcel-bitfly
force-pushed
the
BEDS-128/add-perfectionist-rules
branch
from
d5a529a to
d078761
Compare
See: BIDS-128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://perfectionist.dev/guide/introduction
See: BEDS-128