Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mainHeader): make the user menu panel always open to the left #691

Merged

Conversation

marcel-bitfly
Copy link
Contributor

See: BEDS-221

Copy link

cloudflare-workers-and-pages bot commented Aug 12, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 662dc70
Status: ✅  Deploy successful!
Preview URL: https://bbe16bab.beaconchain.pages.dev
Branch Preview URL: https://beds-221-open-user-menu-drop.beaconchain.pages.dev

View logs

Copy link
Contributor

@MauserBitfly MauserBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine, I just left a small suggestion

// hack: panel should always get opened to the left, but this is not possible with component props
$widthThePanelHasEnoughSpaceToOpenToTheRight: 1558px;
@media screen and (min-width: $widthThePanelHasEnoughSpaceToOpenToTheRight) {
translate: -98px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a more flexible version

Suggested change
translate: -98px;
translate: calc(-100% + 44px);

if we get items with longer texts in the dropdown
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thought about that but gave up to early 💪

@marcel-bitfly marcel-bitfly force-pushed the BEDS-221/open-user-menu-dropdown-to-the-right branch from 8dc89ba to 662dc70 Compare August 12, 2024 13:48
Copy link
Contributor

@MauserBitfly MauserBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcel-bitfly marcel-bitfly merged commit bd88e24 into staging Aug 12, 2024
2 checks passed
@marcel-bitfly marcel-bitfly deleted the BEDS-221/open-user-menu-dropdown-to-the-right branch August 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants