-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BEDS-155) Data Access: adjusted address struct #733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying beaconchain with Cloudflare Pages
|
remoterami
force-pushed
the
BIDS-3245/api-extend-address-field
branch
from
September 11, 2024 12:28
c6324df
to
1eba81a
Compare
Eisei24
suggested changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the address string conversion.
backend/pkg/commons/db/migrations/postgres/20240822134034_add_address_tags.sql
Outdated
Show resolved
Hide resolved
backend/pkg/commons/db/migrations/postgres/20240822134034_add_address_tags.sql
Outdated
Show resolved
Hide resolved
Eisei24
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
guybrush
reviewed
Sep 16, 2024
backend/pkg/commons/db/migrations/postgres/20240822134034_add_address_tags.sql
Show resolved
Hide resolved
guybrush
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
is_contract
and optionallabel
in all cases where an address is retrieved.