Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): source head epoch from slot viz duties response #841

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix(dashboard): source head epoch from slot viz duties response #841

merged 1 commit into from
Sep 9, 2024

Conversation

peterbitfly
Copy link
Contributor

sources the head epoch from the slot viz duties response to avoid data races when setting the latestEpoch cached variable

@peterbitfly peterbitfly requested a review from Eisei24 September 9, 2024 08:08
Eisei24
Eisei24 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterbitfly peterbitfly merged commit adfa096 into staging Sep 9, 2024
2 checks passed
@peterbitfly peterbitfly deleted the BEDS-439/missing_assignments_in_slot_viz branch September 9, 2024 08:24
Eisei24
Eisei24 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eisei24 Eisei24 Eisei24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbitfly @Eisei24