Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beds 200/manage notifications modal #888

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

marcel-bitfly
Copy link
Contributor

@marcel-bitfly marcel-bitfly commented Sep 25, 2024

  • add central store due to common endpoint
  • remove settings provider pattern
  • add vue use library to get rid of custom debounce function

See: BEDS-200

@marcel-bitfly marcel-bitfly force-pushed the BEDS-200/manage-notifications-modal branch from 8e13591 to 85596da Compare September 25, 2024 15:55
Due to an update of VuePrime the `css specifity` must be higher.
- add central store due to common `endpoint`
- remove `settings provider pattern`
- add `vue use` library to get rid of custom `debounce` function

See: BEDS-200
As `console logs` where also lost in development
@marcel-bitfly marcel-bitfly force-pushed the BEDS-200/manage-notifications-modal branch from 85596da to b3a4dec Compare September 27, 2024 07:01
Copy link

cloudflare-workers-and-pages bot commented Sep 27, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: b3a4dec
Status: ✅  Deploy successful!
Preview URL: https://4518b2a6.beaconchain.pages.dev
Branch Preview URL: https://beds-200-manage-notification.beaconchain.pages.dev

View logs

@marcel-bitfly marcel-bitfly reopened this Sep 27, 2024
@marcel-bitfly marcel-bitfly marked this pull request as ready for review September 27, 2024 07:23
@marcel-bitfly marcel-bitfly merged commit 97bea08 into staging Sep 27, 2024
3 checks passed
@marcel-bitfly marcel-bitfly deleted the BEDS-200/manage-notifications-modal branch September 27, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant