Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications-page chores #913

Merged
merged 5 commits into from
Oct 3, 2024
Merged

notifications-page chores #913

merged 5 commits into from
Oct 3, 2024

Conversation

benji-bitfly
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 2, 2024 •
edited
Loading

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b8b736
Status: ✅  Deploy successful!
Preview URL: https://bf70571b.beaconchain.pages.dev
Branch Preview URL: https://beds-475-notifications-page.beaconchain.pages.dev

View logs

@benji-bitfly benji-bitfly force-pushed the BEDS-475/notifications-page-chores branch from f80c8c9 to 37722e7 Compare October 2, 2024 15:11
marcel-bitfly
marcel-bitfly approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@marcel-bitfly marcel-bitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benji-bitfly benji-bitfly force-pushed the BEDS-475/notifications-page-chores branch from daf1536 to 2e5d352 Compare October 3, 2024 09:10
@benji-bitfly benji-bitfly force-pushed the BEDS-475/notifications-page-chores branch 2 times, most recently from 6254dda to 97d393d Compare October 3, 2024 12:31
@benji-bitfly benji-bitfly marked this pull request as ready for review October 3, 2024 12:46
@marcel-bitfly
Copy link
Contributor

np: commit msgs:

  • feat:(NotificationsManagementNetwork): add new reward round toggle
    See: BEDS-201
  • refactor(DashboardValidatorManagementModal): replace lodash with native js
  • style(NotificationsClientsTable): remove comment
  • feat(NotificationsManagementModal): rename network to networks
  • chore(NotificationsManagmentMachines): only show info if there are no machines

@benji-bitfly benji-bitfly force-pushed the BEDS-475/notifications-page-chores branch 3 times, most recently from 3757249 to 0a62d48 Compare October 3, 2024 14:41
@marcel-bitfly
Copy link
Contributor

marcel-bitfly commented Oct 3, 2024 •
edited
Loading

💪 you're making good progress...esp. your clean git history is nice
I also like how you improve things along the way.

@benji-bitfly benji-bitfly force-pushed the BEDS-475/notifications-page-chores branch from 0a62d48 to 4b8b736 Compare October 3, 2024 14:51
@benji-bitfly
Copy link
Contributor Author

💪 you're making good progress...esp. your clean git history is nice I also like how you improve things along the way.

thank you 🙇 but only because I have the opportunity to improve and a great mentor.

@benji-bitfly benji-bitfly merged commit 1b43ede into staging Oct 3, 2024
2 checks passed
@benji-bitfly benji-bitfly deleted the BEDS-475/notifications-page-chores branch October 3, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcel-bitfly marcel-bitfly marcel-bitfly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benji-bitfly @marcel-bitfly