(BEDS-561) validator dashboard details #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_add_group_subs' into BEDS-461/dashboard-details
…s_add_group_subs' into BEDS-461/dashboard-details
Deploying beaconchain with
|
| Latest commit: |
def2488
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cce45313.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-561-dashboard-details.beaconchain.pages.dev |
remoterami
changed the base branch from
staging
to
BEDS-3208/dashboard_notifications_add_group_subs
…s_add_group_subs' into BEDS-561/dashboard-details
remoterami
force-pushed
the
BEDS-561/dashboard-details
branch
from
bccbc58 to
6a231c3
Compare
remoterami
force-pushed
the
BEDS-561/dashboard-details
branch
from
6a231c3 to
c19b723
Compare
peterbitfly
requested changes
Oct 10, 2024
| @@ -253,6 +253,9 @@ func createDataAccessService(cfg *types.Config) *DataAccessService { | |||
| func (d *DataAccessService) StartDataAccessServices() { | |||
| // Create the services | |||
| d.services = services.NewServices(d.readerDb, d.writerDb, d.alloyReader, d.alloyWriter, d.clickhouseReader, d.bigtable, d.persistentRedisDbClient) | |||
|
|
|||
| // Initialize repositories | |||
| d.initNotifications() | |||
There was a problem hiding this comment.
I would prefer if you could call the method registerNotificationInterfaceTypes otherwise one might confuse that the call initialized the full notification system
| @@ -1,6 +1,6 @@ | |||
| // Code generated by tygo. DO NOT EDIT. | |||
There was a problem hiding this comment.
should be acked by @LuccaBitfly
| @@ -113,6 +113,10 @@ export interface ChartHistorySeconds { | |||
| daily: number /* uint64 */; | |||
There was a problem hiding this comment.
should be acked by @LuccaBitfly
peterbitfly
approved these changes
Oct 11, 2024
|
FE lgtm ✔️ |
remoterami
changed the base branch from
BEDS-3208/dashboard_notifications_add_group_subs
to
staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #882