Fix: fix fetcher not to return ctx canceled error #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulmuri
approved these changes
Jul 16, 2024
lsjtop10
commented
Jul 17, 2024
Comment on lines
+107
to
+113
| e, err := ps.cursor.Next(ctx) | ||
|
|
||
| if e.ClosedTime > ps.endTime.Unix() { | ||
| select { | ||
| case <-ps.stop.Done(): | ||
| return nil | ||
| } | ||
|
|
||
| ps.out <- model.Packet{ | ||
| Time: time.Unix(e.ClosedTime, 0), | ||
| Data: e, | ||
| default: | ||
| if e == nil { |
There was a problem hiding this comment.
Next의 위치가 select문 앞으로 와야 Next()도중 context가 cancel되서 발생한 에러를 반환하지 않을 것 같습니다.
mulmuri
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetcher의 NotifyStop이 호출됐을 때 context를 바로 cancel해버리는데 이때 influxdb에서 에러를 반환해서 비정상 종료로 인식되는 문제가 있습니다.