issue-281: add tests and fix panic for * #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivan katliarchuk <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 77.21% 77.31% +0.10%
==========================================
Files 22 22
Lines 7870 7870
==========================================
+ Hits 6077 6085 +8
+ Misses 1374 1368 -6
+ Partials 419 417 -2 |
ccoVeille
reviewed
Jan 12, 2025
Signed-off-by: ivan katliarchuk <[email protected]>
goccy
approved these changes
Jan 16, 2025
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please confirm the following.
partially resolves #281
added tests
fixed null pointer panic with nill guard
while the incorrect behaviour for some paths lookup remains unfixed, a test has been added to reproduce and highlight this issue.
Describe the purpose for which you created this PR.
Create test code that corresponds to the modification