Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: create new kubernetes client per request #163

Closed
wants to merge 1 commit into from
Closed

hotfix: create new kubernetes client per request #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/cd/go/contrib/secrets/kubernetes/KubernetesClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public synchronized KubernetesClient client(SecretConfig secretConfig) {
return this.client;
}

private KubernetesClient createClientFor(SecretConfig secretConfig) {
public static KubernetesClient createClientFor(SecretConfig secretConfig) {
final ConfigBuilder configBuilder = new ConfigBuilder()
.withOauthToken(secretConfig.getSecurityToken())
.withMasterUrl(secretConfig.getClusterUrl())
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cd/go/contrib/secrets/kubernetes/SecretConfigLookupExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class SecretConfigLookupExecutor extends LookupExecutor<SecretConfigReque
@Override
protected GoPluginApiResponse execute(SecretConfigRequest request) {
SecretConfig secretConfig = request.getConfiguration();
KubernetesClient client = KubernetesClientFactory.instance().client(secretConfig);
KubernetesClient client = KubernetesClientFactory.createClientFor(secretConfig);
try {
List<String> secretIds = request.getKeys();
if (secretIds == null || secretIds.isEmpty()) {
Expand Down