Add syntax highlighting for function calls #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @NathanLovato ,
How are you?
Please check if the PR fulfills these requirements:
Related issue (if applicable): Closes #30.
What kind of change does this PR introduce?
The commit add syntax highlighting for function calls.
Does this PR introduce a breaking change?
No.
New feature or change
What is the current behavior?
Function calls are shown in the editor using the regular face.
What is the new behavior?
Function calls are shown in the editor using the
font-lock-function-name-face
.Other information
The implementation uses
"("
instead(syntax open-parenthesis)
asopen-parenthesis
is defined from(open-paren (or "{" "[" "("))
. As a result,the regular expression would also highlight array and dictionary variables.
The regular expression does highlight signal definitions with parameters,
though, as they follow the same pattern of function calls. This could be avoided
by ignoring expressions started with "signal" (or by adding a custom rule to
highlight signal definitions).
I think this closes the last issue that required implementation, as it seems that
#25 was implemented in #27, although it is waiting to be merged in another
repository.
I believe that #13 was addressed by #40. If there is still need to change
something (for instance, introduce a variable to add parameters to the
executable), just let me know.
Best regards,
Franco