-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview Dictionary and Array values in the inspector instead of showing size. #101331
base: master
Are you sure you want to change the base?
Conversation
This effectively removes the array or dictionary size from the 'array preview' which is a very useful UX thing. I would suggest making / waiting for a proposal for a complete redesign of this array or dict preview, because I don't think the design this PR is an improvement from the current UX. The icons are very small and barely readable. There is more information in this preview, but I could argue that that information is not necessarily more useful. |
This is a great improvement to me, but I think the size should still be displayed at the beginning (e.g. between parentheses). For instance:
This could also be |
From the one hand, this allows to see elements without unfolding which is great. |
Alternatively, we could display arrays/dictionaries more efficiently by merging property names and values into a single line. The preview could be slightly grayed out and displayed only when there's enough space. We could add options in editor settings to toggle these previews on/off and adjust their threshold. |
I like the changing the preview color o mark a clearer distinction between the two but mixing the property name and value is clearly a no for me. This would make it too much different from all others property editors and would dilute information and make it harder to read. |
Should fix #101278 (comment)