Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource importer scene: Don't validate save paths when they are UIDs #101509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resource importer scene: Don't validate save paths when they are UIDs #101509

wants to merge 1 commit into from
+3 −1

Conversation

BlueCube3310
Copy link
Contributor

@BlueCube3310 BlueCube3310 commented Jan 13, 2025 •
edited by KoBeWi
Loading

Fixes #101256
Fixes #99573

Ensures that the parent path validation only occurs when the path isn't a UID.

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner January 13, 2025 20:28
@BlueCube3310 BlueCube3310 added this to the 4.4 milestone Jan 13, 2025
@akien-mga akien-mga requested a review from KoBeWi January 13, 2025 20:39
@KoBeWi
Copy link
Member

KoBeWi commented Jan 13, 2025

You can use ResourceUID::ensure_path() to make sure that the path is not uid, then validate it normally. UIDs can be invalid too if the file is deleted.

@KoBeWi
Copy link
Member

KoBeWi commented Jan 14, 2025

#100786 is an alternate solution. It adds a separate field for UID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi Awaiting requested review from KoBeWi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug topic:import
Projects
None yet
Milestone
4.4
2 participants
@BlueCube3310 @KoBeWi