[Windows] Fix handling of paths in console wrapper

[AThousandShips]

Wrapper does not handle paths with spaces

There might be an alternative way to add this or format this, but this solves the problem, I'm surprised this hasn't popped up before (it only did for me now because my new laptop was configured in the store and had "First-name Last-name" as my account, triggering this)

Additionally we might want to make the error message a bit more descriptive (I had to hack in printing the command line string to discover what was even wrong for this), but not touching that right now

Edit: It seems to be in very specific paths, see the report

• Fixes: [Windows] Godot console wrapper fails to launch in certain paths #101303

[bruvzg]

What's exactly no working? Paths with spaces seems to be already handled fine without any changes, I can't reproduce any issues.

[AThousandShips]

I'll send the error message later today, it fails to run if the path to the main executable contains spaces

[bruvzg]

it fails to run if the path to the main executable contains spaces

I have tried path with spaces, and executable name with spaces in various combinations and all work with issues.

[AThousandShips]

The error is CreateProcess failed, error 193, with a path with spaces in the path, not necessarily in the executable

No error with this fix

[bruvzg]

Tried it again and still can't reproduce the issue, but it seems to work the same with this change, so I guess it's OK.

[AThousandShips]

With a user name with a space in it?

[bruvzg]

With a user name with a space in it?

With multiple spaces in the folder names and the executable names in different combinations, not username specifically, but there's nothing special about user folder so it should not matter.

[AThousandShips]

There is, see the issue, it fails specifically with that case

[bruvzg]

Will check it with username in a moment.

CreateProcess failed, error 193

The error is also strange, it's X is not a valid Win32 app. Usually it should indicate the executable is not current (like trying to run ARM64 exe on x86), not a path issue.

[bruvzg]

Will check it with username in a moment.

No, it's still not reproducible.

[AThousandShips]

That is very strange, no clue why it's happening to me specifically

[bruvzg]

Is it a local account or Microsoft account with "Documents" stored in OneDrive? I have tried both fully local and Microsoft accounts with local "Documents", but if it's not in a normal folder, it might have different behavior. Or it's some sort of external interference (like antivirus tempering with disk access, this might also explain strange error 193).

[AThousandShips]

Will check when I'm at my laptop, I don't think it's on OneDrive, it should be a local account