Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add events permissions to default template and create new without eve… #22

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

add events permissions to default template and create new without eve… #22

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c16977
add events permissions to default template and create new without eve…
galco1 Dec 7, 2022
1eb4345
add s3 permissions to default template
galco1 Dec 11, 2022
8df70db
add comments to describe required/featured resources and s3 notificat…
galco1 Dec 12, 2022
ce37ab4
update workflow
galco1 Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/workflow.cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ jobs:
SOURCE_DIR: 'aws_safe_onboarding_template'
DEST_DIR: 'terraform-redactor'
AWS_S3_BUCKET: ${{ env.S3_BUCKET_CLI }}
- name: Upload AWS Eventdriven Boarding Template
- name: Upload AWS Fetching Template without events permissions
uses: jakejarvis/s3-sync-action@master
with:
args: --acl public-read --follow-symlinks --exclude='*' --include='template.yml'
env:
SOURCE_DIR: 'aws_fetching_with_events_permissions_template'
DEST_DIR: 'event-driven'
SOURCE_DIR: 'aws_fetching_readonly_template'
DEST_DIR: 'no-event-driven'
AWS_S3_BUCKET: ${{ env.S3_BUCKET_CLI }}
- name: Upload AWS Eventdriven Boarding Exist Integration Template
uses: jakejarvis/s3-sync-action@master
Expand Down
53 changes: 0 additions & 53 deletions ..._events_permissions_template/template.yml → aws_fetching_readonly_template/template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,52 +184,6 @@ Resources:
- !Join ['/', [!Join ['-', ['arn:aws:s3:::aws-emr-resources', !Ref 'AWS::AccountId', '*']], '*']]
- !Join ['', ['arn:aws:s3:::*/', !Ref 'AWS::AccountId', '*ConfigSnapshot*.json.gz']]

InvokeFireflyEventBusPolicy:
Type: 'AWS::IAM::ManagedPolicy'
Properties:
PolicyDocument:
Version: 2012-10-17
Statement:
- Effect: Allow
Action:
- 'events:PutEvents'
Resource:
- !Join [ ':', [ 'arn:aws:events:us-east-1', !FindInMap [ FireflyEnvironment, env, organizationID ], 'event-bus/prod-stablefly-event-bus' ] ]

InvokeFireflyEventBusRole:
Type: 'AWS::IAM::Role'
Properties:
RoleName: 'invoke-firefly-remote-event-bus'
AssumeRolePolicyDocument:
Version: 2012-10-17
Statement:
- Action: 'sts:AssumeRole'
Effect: Allow
Principal:
Service: "events.amazonaws.com"
ManagedPolicyArns:
- !Ref InvokeFireflyEventBusPolicy

EventbridgePermissions:
Type: 'AWS::IAM::ManagedPolicy'
Properties:
PolicyDocument:
Version: 2012-10-17
Statement:
- Effect: Allow
Action:
- 'events:*'
Resource:
- !Join [ ':', [ 'arn:aws:events:*', !Ref 'AWS::AccountId', 'rule/firefly-events-*' ] ]

- Effect: Allow
Action:
- 'iam:PassRole'
Resource:
- !Join [ ':', [ 'arn:aws:iam:', !Ref 'AWS::AccountId', 'role/invoke-firefly-remote-event-bus'] ]
Condition:
StringEquals:
"iam:PassedToService": "events.amazonaws.com"

FireflyCrossAccountAccessRole:
Type: 'AWS::IAM::Role'
Expand Down Expand Up @@ -257,7 +211,6 @@ Resources:
- 'arn:aws:iam::aws:policy/ReadOnlyAccess'
- !Ref FireflyReadonlyDenylist
- !Ref S3SpecificWritePermission
- !Ref EventbridgePermissions
Outputs:
RoleARN:
Description: >-
Expand All @@ -266,12 +219,6 @@ Outputs:
Value: !GetAtt
- FireflyCrossAccountAccessRole
- Arn
EventsRoleARN:
Description: >-
Access role ARN to invoke firefly event bus
Value: !GetAtt
- InvokeFireflyEventBusRole
- Arn
ExternalID:
Description: ExternalID to share with Firefly
Value: !Ref ExternalID
Expand Down
66 changes: 62 additions & 4 deletions aws_fetching_template/config_template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Resources:
Resource:
- '*'

S3SpecificWritePermission:
S3Permissions:
Type: 'AWS::IAM::ManagedPolicy'
Properties:
PolicyDocument:
Expand All @@ -183,8 +183,59 @@ Resources:
- 'arn:aws:s3:::elasticbeanstalk-*/*'
- !Join ['/', [!Join ['-', ['arn:aws:s3:::aws-emr-resources', !Ref 'AWS::AccountId', '*']], '*']]
- !Join ['', ['arn:aws:s3:::*/', !Ref 'AWS::AccountId', '*ConfigSnapshot*.json.gz']]



- Effect: Allow
Action:
- 's3:PutBucketNotification'
Resource: "arn:aws:s3:::*"

InvokeFireflyEventBusPolicy:
Type: 'AWS::IAM::ManagedPolicy'
Properties:
PolicyDocument:
Version: 2012-10-17
Statement:
- Effect: Allow
Action:
- 'events:PutEvents'
Resource:
- !Join [ ':', [ 'arn:aws:events:us-east-1', !FindInMap [ FireflyEnvironment, env, organizationID ], 'event-bus/prod-stablefly-event-bus' ] ]

InvokeFireflyEventBusRole:
Type: 'AWS::IAM::Role'
Properties:
RoleName: 'invoke-firefly-remote-event-bus'
AssumeRolePolicyDocument:
Version: 2012-10-17
Statement:
- Action: 'sts:AssumeRole'
Effect: Allow
Principal:
Service: "events.amazonaws.com"
ManagedPolicyArns:
- !Ref InvokeFireflyEventBusPolicy

EventbridgePermissions:
Type: 'AWS::IAM::ManagedPolicy'
Properties:
PolicyDocument:
Version: 2012-10-17
Statement:
- Effect: Allow
Action:
- 'events:*'
Resource:
- !Join [ ':', [ 'arn:aws:events:*', !Ref 'AWS::AccountId', 'rule/firefly-events-*' ] ]

- Effect: Allow
Action:
- 'iam:PassRole'
Resource:
- !Join [ ':', [ 'arn:aws:iam:', !Ref 'AWS::AccountId', 'role/invoke-firefly-remote-event-bus'] ]
Condition:
StringEquals:
"iam:PassedToService": "events.amazonaws.com"

FireflyCrossAccountAccessRole:
Type: 'AWS::IAM::Role'
Properties:
Expand All @@ -210,7 +261,8 @@ Resources:
- 'arn:aws:iam::aws:policy/SecurityAudit'
- 'arn:aws:iam::aws:policy/ReadOnlyAccess'
- !Ref FireflyReadonlyDenylist
- !Ref S3SpecificWritePermission
- !Ref S3Permissions
- !Ref EventbridgePermissions
Outputs:
RoleARN:
Description: >-
Expand All @@ -219,6 +271,12 @@ Outputs:
Value: !GetAtt
- FireflyCrossAccountAccessRole
- Arn
EventsRoleARN:
Description: >-
Access role ARN to invoke firefly event bus
Value: !GetAtt
- InvokeFireflyEventBusRole
- Arn
ExternalID:
Description: ExternalID to share with Firefly
Value: !Ref ExternalID
Expand Down