Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn on potentially unsafe HTML comments when unsafe=false #13288

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bep
Copy link
Member

@bep bep commented Jan 21, 2025

We will still not render these comments, so from a safety perspective this is the same, but HTML comments are very common also inside Markdown and too useful to throw away.

Updates #13278

We will still not render these comments, so from a safety perspective this is the same, but HTML comments are very common also inside Markdown and too useful to throw away.

Updates gohugoio#13278
@bep bep requested a review from jmooring January 21, 2025 10:58
@jmooring
Copy link
Member

The blocks work great, but these emit warnings:

This is a <!--hidden--> word.

This is a <!-- hidden--> word.

This is a <!-- hidden --> word.

This is a <!-- 
hidden --> word.

This is a <!-- 
hidden
--> word.

@bep
Copy link
Member Author

bep commented Jan 21, 2025

Thanks, I forgot that we had 2 variants, pushed a fixed in 22145b5

Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great. When released we should immediately deprecate the comment shortcode (emit warning). After a year or so throw an error. And probably keep that one-line shortcode for a few years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants