-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option: run_once, and removed skip_waiting #7
base: main
Are you sure you want to change the base?
Conversation
@damdo How do you work in the way of tests and CI? Are there going to be github actions running for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mpl the PR looks good to me, added two little nitpicks but nothing blocking.
At the moment I use a very rough make target that I have checked in here: https://github.com/gokrazy/selfupdate/tree/e2e-test |
@damdo do you prefer the --amend+push force flow (I'm used to it because of reasons), or do you want distinct commits on the PR, and we squash them all at merge time? |
Fine to amen + force push :) thanks for asking @mpl |
- new default behaviour: an update check is always attempted right from the start, regardless of check_frequency value. - run_once: controls whether we exit right after the initial update check. - skip_waiting: removed Fixes gokrazy#6
Thanks @mpl will do a manual test and add my review |
Fixes #6