Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option: run_once, and removed skip_waiting #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mpl
Copy link
Contributor

@mpl mpl commented Jan 15, 2025

  • new default behaviour: an update check is always attempted right from the start, regardless of check_frequency value.
  • run_once: controls whether we exit right after the initial update check.
  • skip_waiting: removed

Fixes #6

@mpl
Copy link
Contributor Author

mpl commented Jan 15, 2025

@damdo How do you work in the way of tests and CI? Are there going to be github actions running for this?
Disclaimer: I'm doing this PR on my mac, so I haven't tried building it or testing it (yet).

Copy link
Collaborator

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpl the PR looks good to me, added two little nitpicks but nothing blocking.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@damdo
Copy link
Collaborator

damdo commented Jan 15, 2025

@damdo How do you work in the way of tests and CI? Are there going to be github actions running for this?
Disclaimer: I'm doing this PR on my mac, so I haven't tried building it or testing it (yet).

At the moment I use a very rough make target that I have checked in here: https://github.com/gokrazy/selfupdate/tree/e2e-test
The plan is to finish off gokrazy/tools#62 and then turn this into a go e2e test that we can run on GH actions.

@mpl
Copy link
Contributor Author

mpl commented Jan 16, 2025

@damdo do you prefer the --amend+push force flow (I'm used to it because of reasons), or do you want distinct commits on the PR, and we squash them all at merge time?

@damdo
Copy link
Collaborator

damdo commented Jan 16, 2025

Fine to amen + force push :) thanks for asking @mpl

- new default behaviour: an update check is always attempted right from
  the start, regardless of check_frequency value.
- run_once: controls whether we exit right after the initial update
  check.
- skip_waiting: removed

Fixes gokrazy#6
@damdo
Copy link
Collaborator

damdo commented Jan 16, 2025

Thanks @mpl will do a manual test and add my review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support skipWaiting initially but keep periodically checking afterwards
2 participants