Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts-vitest): fixed ESM build for ts-vitest #706

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

Cellule
Copy link
Contributor

@Cellule Cellule commented Mar 4, 2024

ts-vitest is meant to be imported by vitest as such it needs to be a proper ESM module. The package.json already defined it as "type": "module", but the typescript build was still generating a CommonJS build. This fix updates the typescript configuration to output an ESM module.

re #613

ts-vitest is meant to be imported by vitest as such it needs to be a proper ESM module. The
package.json already defined it as "type": "module", but the typescript build was still generating a
CommonJS build. This fix updates the typescript configuration to output an ESM module.

re golevelup#613
@underfisk underfisk enabled auto-merge (squash) March 6, 2024 11:57
@underfisk underfisk merged commit a78778c into golevelup:master Mar 6, 2024
3 checks passed
WonderPanda pushed a commit that referenced this pull request Apr 10, 2024
ts-vitest is meant to be imported by vitest as such it needs to be a proper ESM module. The
package.json already defined it as "type": "module", but the typescript build was still generating a
CommonJS build. This fix updates the typescript configuration to output an ESM module.

re #613
WonderPanda pushed a commit that referenced this pull request Apr 10, 2024
ts-vitest is meant to be imported by vitest as such it needs to be a proper ESM module. The
package.json already defined it as "type": "module", but the typescript build was still generating a
CommonJS build. This fix updates the typescript configuration to output an ESM module.

re #613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants