Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hasura): handle both "one off" and "cron" type scheduled events #761

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix(hasura): handle both "one off" and "cron" type scheduled events #761

merged 1 commit into from
Aug 14, 2024

Conversation

mattgstevens
Copy link
Contributor

…d events

fix #760

Copy link
Contributor

@underfisk underfisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, i would love to hear @WonderPanda feedback on this one e

@underfisk underfisk requested a review from WonderPanda August 13, 2024 18:49
@WonderPanda
Copy link
Collaborator

This seems like reasonable behavior to me. Checking the comment always felt a little bit off

@WonderPanda WonderPanda changed the title fix: hasura module can handle both "one off" and "cron" type schedule… fix(hasura): handle both "one off" and "cron" type scheduled events Aug 14, 2024
@WonderPanda WonderPanda merged commit 9590f28 into golevelup:master Aug 14, 2024
3 checks passed
@mattgstevens mattgstevens deleted the fix/760-hasura-scheduled-events branch August 15, 2024 07:10
@mattgstevens
Copy link
Contributor Author

@WonderPanda is there an ETA on next release?
not sure what kind of release schedule this package follows

@WonderPanda
Copy link
Collaborator

@WonderPanda is there an ETA on next release? not sure what kind of release schedule this package follows

The fix should be available now in @golevelup/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hasura Scheduled Event Trigger Payload - does not support Cron Trigger type
3 participants