Bump node versions and ci matrix #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW ci passes in my repo: https://github.com/barraponto/golevelup-nestjs/actions/runs/10532889002?pr=1 |
underfisk
reviewed
Aug 26, 2024
|
Something needs to be configured because this PR removes node 19 support, but github actions is still expecting it... |
Yes, I don't have permissions to bypass this, only @WonderPanda |
|
Bump @WonderPanda |
|
Sorry guys. I've removed the branch protection requirement for Node 19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both node 19 and 21 went the way of the dodo already.
Let's not hold @golevelup/ts-vitest back because of those versions.
Also, let's extend the ci matrix to node 22, for good measure.