Import biogo.graphics palettes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| package brewer | ||
|
|
||
| import ( | ||
| "code.google.com/p/biogo.graphics/palette" |
There was a problem hiding this comment.
shouldn't this be github.com/gonum/plot/palette ?
|
PTAL |
| d := int64(a) - int64(b) | ||
| if d < 0 { | ||
| if d == -d { | ||
| panic("color: weird number overflow") |
|
perhaps also add a simple example? other than that: LGTM |
Minor changes to packages in that repo: * Change from gocheck to testing. * golint changes.
|
I can't think of any non-facile example, so I'll push this. If you want I can revisit this after discussion.
|
|
Is it appropriate to use this in plotutil to replace the various color slices? If so, open an issue so that we don't forget. |
|
That can be done. I'll send a PR today.
|
|
Actually, this requires further discussion since there are at least a couple of different approaches, so #11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to packages in that repo:
All AUTHORS of this code are already in gonum/A+C (me and my employer). biogo copyright notices are retained purely for historical reasons.