Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration for Pylint from .pylintrc to pyproject.toml. #1160

Conversation

carlosgmartin
Copy link
Contributor

@carlosgmartin carlosgmartin commented Dec 19, 2024

This is a follow-up to

To prevent confusion and duplication of work, I will try to keep further improvements as atomic as possible.

The sole purpose of this PR is to move the configuration for Pylint from .pylintrc to the standardized place for configuration of Python projects, namely pyproject.toml.

Future PRs will re-enable some of the disabled Pylint warnings after editing the code that triggers them.

@carlosgmartin carlosgmartin force-pushed the move_pylintrc_config_to_pyproject_toml branch from 7664c65 to c964411 Compare December 19, 2024 21:28
@carlosgmartin
Copy link
Contributor Author

@vroulet @fabianp How does this look? After this PR is merged, I can try to re-enable some of the warnings.

@fabianp
Copy link
Member

fabianp commented Feb 2, 2025

hey, this looks good to me, but the flake8 tests seem to be broken

@carlosgmartin carlosgmartin force-pushed the move_pylintrc_config_to_pyproject_toml branch from c964411 to caf75a0 Compare February 2, 2025 19:40
@carlosgmartin
Copy link
Contributor Author

@fabianp I think it's fixed now.

@copybara-service copybara-service bot merged commit 8cb6a0e into google-deepmind:main Feb 4, 2025
12 checks passed
@carlosgmartin carlosgmartin deleted the move_pylintrc_config_to_pyproject_toml branch February 4, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants