Make TimeVaryingArray and TimeVaryingScalar immutable. This is with a view to make the full model config immutable, which makes it possible to safely cache computations inside the model without worrying that a user has modified the field of eg. TimeVaryingArray, which is undetectable from a higher-level without major overhead. #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_725811399
branch
from
75c1d04 to
9c4d169
Compare
… view to make the full model config immutable, which makes it possible to safely cache computations inside the model without worrying that a user has modified the field of eg. TimeVaryingArray, which is undetectable from a higher-level without major overhead. This also reduces construction overhead of TimeVaryingArray, as the validators are no longer run on assignment of the grid, which has to happen after construction of the TimeVaryingArray class. PiperOrigin-RevId: 725811399
copybara-service
bot
force-pushed
the
test_725811399
branch
from
9c4d169 to
0524771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make TimeVaryingArray and TimeVaryingScalar immutable. This is with a view to make the full model config immutable, which makes it possible to safely cache computations inside the model without worrying that a user has modified the field of eg. TimeVaryingArray, which is undetectable from a higher-level without major overhead.
This also reduces construction overhead of TimeVaryingArray, as the validators are no longer run on assignment of the grid, which has to happen after construction of the TimeVaryingArray class.