-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to AutoValue.Id. #212
Open
rdtorres
wants to merge
1
commit into
google:main
Choose a base branch
from
rdtorres:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
value/src/main/java/com/google/auto/value/processor/AutoValueIdsProcessor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright (C) 2014 Google, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.auto.value.processor; | ||
|
|
||
| import com.google.auto.common.MoreElements; | ||
| import com.google.auto.common.SuperficialValidation; | ||
| import com.google.auto.service.AutoService; | ||
| import com.google.auto.value.AutoValue; | ||
| import com.google.common.collect.ImmutableSet; | ||
|
|
||
| import javax.annotation.processing.AbstractProcessor; | ||
| import javax.annotation.processing.Processor; | ||
| import javax.annotation.processing.RoundEnvironment; | ||
| import javax.lang.model.SourceVersion; | ||
| import javax.lang.model.element.Element; | ||
| import javax.lang.model.element.TypeElement; | ||
| import javax.tools.Diagnostic; | ||
| import java.util.Set; | ||
|
|
||
| import static com.google.auto.common.MoreElements.isAnnotationPresent; | ||
|
|
||
| /** | ||
| * Annotation processor that checks that the type that {@link com.google.auto.value.AutoValue.Id} | ||
| * is applied to is nested inside an {@code @AutoValue} class. The actual code generation for ids | ||
| * is done in {@link AutoValueProcessor}. | ||
| * | ||
| * @author Rafael Torres | ||
| */ | ||
| @AutoService(Processor.class) | ||
| public class AutoValueIdsProcessor extends AbstractProcessor { | ||
| @Override | ||
| public Set<String> getSupportedAnnotationTypes() { | ||
| return ImmutableSet.of( | ||
| AutoValue.Id.class.getCanonicalName()); | ||
| } | ||
|
|
||
| @Override | ||
| public SourceVersion getSupportedSourceVersion() { | ||
| return SourceVersion.latest(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) { | ||
| Set<? extends Element> idsMethods = | ||
| roundEnv.getElementsAnnotatedWith(AutoValue.Id.class); | ||
| if (!SuperficialValidation.validateElements(idsMethods)) { | ||
| return false; | ||
| } | ||
| for (Element annotatedMethod : idsMethods) { | ||
| if (isAnnotationPresent(annotatedMethod, AutoValue.Id.class)) { | ||
| validate( | ||
| annotatedMethod, | ||
| "@AutoValue.Id can only be applied to a method inside an @AutoValue class"); | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| private void validate(Element annotatedType, String errorMessage) { | ||
| Element container = annotatedType.getEnclosingElement(); | ||
| if (!MoreElements.isAnnotationPresent(container, AutoValue.class)) { | ||
| processingEnv.getMessager().printMessage( | ||
| Diagnostic.Kind.ERROR, errorMessage, annotatedType); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not sure if I should create another processor to validate Id or if I should use AutoValueBuilderProcessor. My suggestion is to rename AutoValueBuilderProcessor to some generic name and use it to validate Builder, Validate and Id.