correct function signature on HWY_SCALAR branch #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes build error on RISCV which does not have a dedicated SIMD implementation.
qtprojectorg
pushed a commit
to qt/qtwebengine-chromium
that referenced
this pull request
Jun 3, 2024
Fix function signature, most liekly fixed upstream at some point. Fixes armv7 compilation on ci. Same fix upstream: google/distributed_point_functions#198 Change-Id: I29260478cda231b06b8c86caa6852c0400c400bd Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/564690 Reviewed-by: Peter Varga <[email protected]>
qtprojectorg
pushed a commit
to qt/qtwebengine-chromium
that referenced
this pull request
Aug 15, 2024
Fix function signature, most liekly fixed upstream at some point. Fixes armv7 compilation on ci. Same fix upstream: google/distributed_point_functions#198 Change-Id: I29260478cda231b06b8c86caa6852c0400c400bd Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/564690 Reviewed-by: Peter Varga <[email protected]>
qtprojectorg
pushed a commit
to qt/qtwebengine-chromium
that referenced
this pull request
Dec 3, 2024
Fix function signature, most liekly fixed upstream at some point. Fixes armv7 compilation on ci. Same fix upstream: google/distributed_point_functions#198 Change-Id: I29260478cda231b06b8c86caa6852c0400c400bd Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/564690 Reviewed-by: Peter Varga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build error on RISCV which does not have a dedicated SIMD implementation.