Turn sinkFhirServerUrl off by default but on in e2e #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1075 +/- ##
============================================
- Coverage 50.55% 50.44% -0.11%
+ Complexity 674 673 -1
============================================
Files 91 91
Lines 5519 5519
Branches 709 709
============================================
- Hits 2790 2784 -6
- Misses 2467 2473 +6
Partials 262 262 ☔ View full report in Codecov by Sentry. |
bashir2
force-pushed
the
disableSinkDefault
branch
from
bf5d56e to
84ee768
Compare
bashir2
force-pushed
the
disableSinkDefault
branch
from
84ee768 to
3bd8c81
Compare
|
@mozzy11 FYI with this PR I am removing the sink FHIR-server from the default config but still enabling it for e2e. When you want to use this feature in your environment, please note this. |
chandrashekar-s
approved these changes
May 30, 2024
There was a problem hiding this comment.
Thanks @bashir2 for the changes. There is only one minor comment, you can merge the changes once it is resolved.
bashir2
commented
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
With #947 we have enabled sending FHIR resources to a sink server. Turning this on by default, requires an additional setup step of running a sink FHIR server which is not needed for most users (and also is an experimental feature). I am turning this off in the default config but turning it on in e2e since we have tests around it.
E2E test
TESTED:
Built and ran the docker image locally in the "off case"; relying on e2e for the "on case".
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master