Skip to content

Commit

Permalink
Address the comments
Browse files Browse the repository at this point in the history
  • Loading branch information
show50726 committed Feb 4, 2025
1 parent 0e4cfc2 commit 8715fc5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion libs/fgviewer/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ set(SRCS
src/ApiHandler.h
src/DebugServer.cpp
src/FrameGraphInfo.cpp
src/JsonWriter.cpp
src/JsonWriter.cpp
)

# ==================================================================================================
Expand Down
5 changes: 2 additions & 3 deletions libs/fgviewer/src/ApiHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ bool ApiHandler::handleGet(CivetServer* server, struct mg_connection* conn) {
}

if (uri == "/api/framegraph") {
const FrameGraphInfo* result = getFrameGraphInfo(conn, request);
const FrameGraphInfo* result = getFrameGraphInfo(request);
if (!result) {
return error(__LINE__, uri);
}
Expand All @@ -94,8 +94,7 @@ void ApiHandler::updateFrameGraph(ViewHandle view_handle) {
mStatusCondition.notify_all();
}

const FrameGraphInfo* ApiHandler::getFrameGraphInfo(struct mg_connection* conn,
struct mg_request_info const* request) {
const FrameGraphInfo* ApiHandler::getFrameGraphInfo(struct mg_request_info const* request) {
size_t const qlength = strlen(request->query_string);
char fgid[9] = {};
if (mg_get_var(request->query_string, qlength, "fgid", fgid, sizeof(fgid)) < 0) {
Expand Down
3 changes: 1 addition & 2 deletions libs/fgviewer/src/ApiHandler.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ class ApiHandler : public CivetHandler {
void updateFrameGraph(ViewHandle view_handle);

private:
const FrameGraphInfo* getFrameGraphInfo(struct mg_connection* conn,
struct mg_request_info const* request);
const FrameGraphInfo* getFrameGraphInfo(struct mg_request_info const* request);

bool handleGetStatus(struct mg_connection* conn,
struct mg_request_info const* request);
Expand Down

0 comments on commit 8715fc5

Please sign in to comment.