[Depends on #8344] Implement ApiHandler functions and add JsonWriter #8379
+300
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libs/fgviewer/include/fgviewer/DebugServer.h # libs/fgviewer/include/fgviewer/FrameGraphInfo.h # libs/fgviewer/src/FrameGraphInfo.cpp
show50726
requested review from
pixelflinger and
poweifeng
and removed request for
pixelflinger
libs/fgviewer/src/ApiHandler.h
Outdated
| // This variable is to implement a *hanging* effect for /api/status. The call to /api/status | ||
| // will always block until statusMaterialId is updated again. The client is expected to keep | ||
| // calling /api/status (a constant "pull" to simulate a push). | ||
| std::atomic<uint64_t> mCurrentStatus = 0; |
There was a problem hiding this comment.
I don't understand why this needs to be an atomic since it's protected by the mutex? Also I don't see it being updated anywhere?
There was a problem hiding this comment.
Yeah, we might not need to make it atomic. I've updated the code.
Also, I add the call to updateFrameGraph when a view is created and updated, and it will only be updated when the content of the info is changed.
# Conflicts: # filament/src/details/Engine.cpp
poweifeng
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after #8344 is in.
ApiHandlerGET /api/framegraphs: for getting all active frame graph infoGET /api/framegraph?fg={fgid}: for getting specific view's frame graph infoGET /api/status: for long polling, notify the client if there's any view's frame graph updatedJsonWriterclass for convertingFrameGraphInfoto json format