Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lazy_dataset after it has been deprecated for a while. #670

Merged
merged 1 commit into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions grain/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -49,23 +49,12 @@ py_library(
srcs_version = "PY3",
# Implicit build flag
deps = [
":python_lazy_dataset", # build_cleaner: keep
"//grain/_src/core:transforms", # build_cleaner: keep
"//grain/_src/python/dataset:visualize", # build_cleaner: keep
"//grain/_src/python/dataset/transformations:interleave", # build_cleaner: keep
"//grain/_src/python/experimental/example_packing:packing", # build_cleaner: keep
],
)

py_library(
name = "python_lazy_dataset",
srcs = ["python_lazy_dataset.py"],
srcs_version = "PY3",
# Implicit build flag
deps = [
"//grain/_src/python/dataset", # build_cleaner: keep
"//grain/_src/python/dataset/transformations:flatmap", # build_cleaner: keep
"//grain/_src/python/dataset/transformations:interleave", # build_cleaner: keep
"//grain/_src/python/dataset/transformations:packing", # build_cleaner: keep
"//grain/_src/python/dataset/transformations:zip", # build_cleaner: keep
"//grain/_src/python/experimental/example_packing:packing", # build_cleaner: keep
],
)
2 changes: 1 addition & 1 deletion grain/_src/python/dataset/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""LazyDataset base classes.
"""Dataset base classes.

There are 3 main classes:
- `MapDataset` define a dataset that supports efficient random access. It
Expand Down
10 changes: 0 additions & 10 deletions grain/python_experimental.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,6 @@
# pylint: disable=wildcard-import
# pylint: disable=g-import-not-at-top

from etils import epy

# `lazy_dataset` module is deprecated. It displays the deprecation message upon
# import. We make the import lazy to only display the message when the module
# is actually used.
with epy.lazy_imports():
from grain import python_lazy_dataset as lazy_dataset

del epy

from ._src.python.dataset.base import (
DatasetOptions,
ExecutionTrackingMode,
Expand Down
81 changes: 0 additions & 81 deletions grain/python_lazy_dataset.py

This file was deleted.

Loading