#grain Simplify state management in FirstFitPackingIterator. #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_720605062
branch
5 times, most recently
from
461912c to
62b5567
Compare
The conditional in get_state() was making the class hard to reason about. Now we have a single field for holding the checkpointed parent state. We advance it whenever a batch is fully emitted, since at that point the parent will no longer need to be rewound to before the batch. PiperOrigin-RevId: 720967916
copybara-service
bot
force-pushed
the
test_720605062
branch
from
62b5567 to
a7d1ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#grain Simplify state management in FirstFitPackingIterator.
The conditional in get_state() was making the class hard to reason about.
Now we have a single field for holding the checkpointed parent state. We advance it whenever a batch is fully emitted, since at that point the parent will no longer need to be rewound to before the batch.