Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running StackOverflowError tests under Android. #7637

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Stop running StackOverflowError tests under Android. #7637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion android/guava-tests/test/com/google/common/util/concurrent/AbstractFutureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ public void testSetFuture_stackOverflow() {
// call to fail
@J2ktIncompatible
@GwtIncompatible
@AndroidIncompatible
@AndroidIncompatible // b/391667564: crashes from stack overflows
public void testSetFutureToString_stackOverflow() {
SettableFuture<String> orig = SettableFuture.create();
SettableFuture<String> prev = orig;
Expand Down Expand Up @@ -989,6 +989,7 @@ public String toString() {
+ " java.lang.NullPointerException]]");
}

@AndroidIncompatible // b/391667564: crashes from stack overflows
public void testSetIndirectSelf_toString() {
final SettableFuture<Object> orig = SettableFuture.create();
// unlike the above this indirection defeats the trivial cycle detection and causes a SOE
Expand Down
14 changes: 4 additions & 10 deletions android/guava-tests/test/com/google/common/util/concurrent/FuturesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,7 @@ public BarChild apply(Foo unused) {
assertSame(barChild, bar);
}

/*
* Android does not handle this stack overflow gracefully... though somehow some other
* stack-overflow tests work. It must depend on the exact place the error occurs.
*/
@AndroidIncompatible
@AndroidIncompatible // b/391667564: crashes from stack overflows
@J2ktIncompatible
@GwtIncompatible // StackOverflowError
public void testTransform_stackOverflow() throws Exception {
Expand Down Expand Up @@ -473,11 +469,7 @@ public ListenableFuture<Bar> apply(Foo unused) {
assertFalse(((AbstractFuture<?>) f2).wasInterrupted());
}

/*
* Android does not handle this stack overflow gracefully... though somehow some other
* stack-overflow tests work. It must depend on the exact place the error occurs.
*/
@AndroidIncompatible
@AndroidIncompatible // b/391667564: crashes from stack overflows
@J2ktIncompatible
@GwtIncompatible // StackOverflowError
public void testTransformAsync_stackOverflow() throws Exception {
Expand Down Expand Up @@ -1316,6 +1308,7 @@ public void testCatching_customTypeNoMatch() throws Exception {
assertThat(expected).hasCauseThat().isInstanceOf(RuntimeException.class);
}

@AndroidIncompatible // b/391667564: crashes from stack overflows
@J2ktIncompatible
@GwtIncompatible // StackOverflowError
public void testCatching_stackOverflow() throws Exception {
Expand Down Expand Up @@ -1445,6 +1438,7 @@ public void testCatchingAsync_customTypeNoMatch() throws Exception {
assertThat(expected).hasCauseThat().isInstanceOf(RuntimeException.class);
}

@AndroidIncompatible // b/391667564: crashes from stack overflows
@J2ktIncompatible
@GwtIncompatible // StackOverflowError
public void testCatchingAsync_stackOverflow() throws Exception {
Expand Down
3 changes: 2 additions & 1 deletion guava-tests/test/com/google/common/util/concurrent/AbstractFutureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ public void testSetFuture_stackOverflow() {
// call to fail
@J2ktIncompatible
@GwtIncompatible
@AndroidIncompatible
@AndroidIncompatible // b/391667564: crashes from stack overflows
public void testSetFutureToString_stackOverflow() {
SettableFuture<String> orig = SettableFuture.create();
SettableFuture<String> prev = orig;
Expand Down Expand Up @@ -989,6 +989,7 @@ public String toString() {
+ " java.lang.NullPointerException]]");
}

@AndroidIncompatible // b/391667564: crashes from stack overflows
public void testSetIndirectSelf_toString() {
final SettableFuture<Object> orig = SettableFuture.create();
// unlike the above this indirection defeats the trivial cycle detection and causes a SOE
Expand Down
14 changes: 4 additions & 10 deletions guava-tests/test/com/google/common/util/concurrent/FuturesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,7 @@ public BarChild apply(Foo unused) {
assertSame(barChild, bar);
}

/*
* Android does not handle this stack overflow gracefully... though somehow some other
* stack-overflow tests work. It must depend on the exact place the error occurs.
*/
@AndroidIncompatible
@AndroidIncompatible // b/391667564: crashes from stack overflows
@J2ktIncompatible
@GwtIncompatible // StackOverflowError
public void testTransform_stackOverflow() throws Exception {
Expand Down Expand Up @@ -473,11 +469,7 @@ public ListenableFuture<Bar> apply(Foo unused) {
assertFalse(((AbstractFuture<?>) f2).wasInterrupted());
}

/*
* Android does not handle this stack overflow gracefully... though somehow some other
* stack-overflow tests work. It must depend on the exact place the error occurs.
*/
@AndroidIncompatible
@AndroidIncompatible // b/391667564: crashes from stack overflows
@J2ktIncompatible
@GwtIncompatible // StackOverflowError
public void testTransformAsync_stackOverflow() throws Exception {
Expand Down Expand Up @@ -1316,6 +1308,7 @@ public void testCatching_customTypeNoMatch() throws Exception {
assertThat(expected).hasCauseThat().isInstanceOf(RuntimeException.class);
}

@AndroidIncompatible // b/391667564: crashes from stack overflows
@J2ktIncompatible
@GwtIncompatible // StackOverflowError
public void testCatching_stackOverflow() throws Exception {
Expand Down Expand Up @@ -1445,6 +1438,7 @@ public void testCatchingAsync_customTypeNoMatch() throws Exception {
assertThat(expected).hasCauseThat().isInstanceOf(RuntimeException.class);
}

@AndroidIncompatible // b/391667564: crashes from stack overflows
@J2ktIncompatible
@GwtIncompatible // StackOverflowError
public void testCatchingAsync_stackOverflow() throws Exception {
Expand Down
Loading