Run a test under more environments. #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
It hasn't actually used "mocks" in the sense of "things from a mocking framework" since cl/85631779, which (confusingly) appears to have been the CL that _added_ the "mocks" comment (to replace a previous `@GwtIncompatible` comment about `withFallback`, which wasn't available under GWT until then). (Probably the author had switched away from using a mocking framework during development but then forgotten to remove `@GwtIncompatible` afterward.) It looks like I carried that comment over from `withFallback` to `catchingAsync` in cl/86180055, and then I added a corresponding TODO in cl/116759522. None of that seems to have been necessary. RELNOTES=n/a PiperOrigin-RevId: 723210249
copybara-service
bot
force-pushed
the
test_723157346
branch
from
b4cea15 to
453549c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run a test under more environments.
It hasn't actually used "mocks" in the sense of "things from a mocking framework" since cl/85631779, which (confusingly) appears to have been the CL that added the "mocks" comment (to replace a previous
@GwtIncompatiblecomment aboutwithFallback, which wasn't available under GWT until then). (Probably the author had switched away from using a mocking framework during development but then forgotten to remove@GwtIncompatibleafterward.) It looks like I carried that comment over fromwithFallbacktocatchingAsyncin cl/86180055, and then I added a corresponding TODO in cl/116759522. None of that seems to have been necessary.RELNOTES=n/a