Disable two assertions for j2kt that are only passing by accident #7654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_725236904
branch
from
36bb861 to
3edfdb8
Compare
The implementation code expects `Comparable` implementations to throw `ClassCastException`s when trying to compare to objects of the wrong type. Kotlin/Native `Comparable`s don’t make this guarantee yet (This is expected to change when https://youtrack.jetbrains.com/issue/KT-71001/ is fixed). The assertions are preventing us from making a compiler flag change that changes the behavior that made these assertions pass accidentally. PiperOrigin-RevId: 725264702
copybara-service
bot
force-pushed
the
test_725236904
branch
from
3edfdb8 to
8ea070f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable two assertions for j2kt that are only passing by accident
The implementation code expects
Comparableimplementations to throwClassCastExceptions when trying to compare to objects of the wrong type.Kotlin/Native
Comparables don’t make this guarantee yet (This is expected tochange when https://youtrack.jetbrains.com/issue/KT-71001/ is fixed).
The assertions are preventing us from making a compiler flag change that changes
the behavior that made these assertions pass accidentally.