Include Python module and Bazel build in the build-and-test workflow #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbartholomew
changed the title
johnbartholomew
force-pushed
the
ci-test-python
branch
from
e416417 to
69512da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1121:
python setup.py build,python setup.py test, as in the README).bazel build //cmd:all,bazel test //..., as in the README)The Travis workflow included building and running the Python module, and it seems worth replicating that in the new GitHub build-and-test workflow. I think the Bazel build is worth checking as well.
This PR also includes a commit that removes some unnecessary empty prebuild steps from the workflow configuration (which I should have cleaned up right at the start before merging the workflow config initially, but never mind).