Handle gin.bind_parameter in tests
#395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a test needs to `gin.bind_parameter` it should also clear that, or make the binding within a `gin.config_scope`, otherwise the bindings may leak to other tests if all the tests are run by e.g. pytest. This patch uses both approaches: for tests that set up bindings in `setUp` we clear in `tearDown`, else we use the scoped approach. Issue google#394
|
Note: tested by re-running PR #393 with the explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test needs to
gin.bind_parameterit should also clear that, or make the binding within agin.config_scope, otherwise the bindings may leak to other tests if all the tests are run by e.g. pytest.This patch uses both approaches: for tests that set up bindings in
setUpwe clear intearDown, else we use the scoped approach.Issue #394