Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ct: Specify direction for saddr, daddr, proto-src, proto-dst #264

Merged
merged 2 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions expr/ct.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ type Ct struct {
Register uint32
SourceRegister bool
Key CtKey
Direction uint32
}

func (e *Ct) marshal(fam byte) ([]byte, error) {
Expand Down Expand Up @@ -102,6 +103,20 @@ func (e *Ct) marshalData(fam byte) ([]byte, error) {
return nil, err
}
exprData = append(exprData, regData...)

switch e.Key {
case CtKeySRC, CtKeyDST, CtKeyPROTOSRC, CtKeyPROTODST:
regData, err = netlink.MarshalAttributes(
[]netlink.Attribute{
{Type: unix.NFTA_CT_DIRECTION, Data: binaryutil.BigEndian.PutUint32(e.Direction)},
},
)
if err != nil {
return nil, err
}
exprData = append(exprData, regData...)
}

return exprData, nil
}

Expand All @@ -117,6 +132,8 @@ func (e *Ct) unmarshal(fam byte, data []byte) error {
e.Key = CtKey(ad.Uint32())
case unix.NFTA_CT_DREG:
e.Register = ad.Uint32()
case unix.NFTA_CT_DIRECTION:
e.Direction = ad.Uint32()
}
}
return ad.Err()
Expand Down
69 changes: 69 additions & 0 deletions expr/ct_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
package expr

import (
"encoding/binary"
"reflect"
"testing"

"github.com/mdlayher/netlink"
"golang.org/x/sys/unix"
)

func TestCt(t *testing.T) {
t.Parallel()
tests := []struct {
name string
ct Ct
}{
{
name: "Unmarshal Ct status case",
ct: Ct{
Register: 1,
Key: CtKeySTATUS,
},
},
{
name: "Unmarshal Ct proto-dst direction original case",
ct: Ct{
Register: 1,
Key: CtKeyPROTODST,
Direction: 0, // direction: original
},
},
{
name: "Unmarshal Ct src direction reply case",
ct: Ct{
Register: 1,
Key: CtKeySRC,
Direction: 1, // direction: reply
},
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
nct := Ct{}
data, err := tt.ct.marshal(0 /* don't care in this test */)
if err != nil {
t.Fatalf("marshal error: %+v", err)

}
ad, err := netlink.NewAttributeDecoder(data)
if err != nil {
t.Fatalf("NewAttributeDecoder() error: %+v", err)
}
ad.ByteOrder = binary.BigEndian
for ad.Next() {
if ad.Type() == unix.NFTA_EXPR_DATA {
if err := nct.unmarshal(0, ad.Bytes()); err != nil {
t.Errorf("unmarshal error: %+v", err)
break
}
}
}
if !reflect.DeepEqual(tt.ct, nct) {
t.Fatalf("original %+v and recovered %+v Ct structs are different", tt.ct, nct)
}
})
}
}
Loading