Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for adding comment in set elements #293

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

shiningw
Copy link
Contributor

@shiningw shiningw commented Jan 9, 2025

Hi,
This PR adds support for embedding comments within set elements. I find it useful and others may also need this.

Copy link

google-cla bot commented Jan 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@stapelberg
Copy link
Collaborator

@turekt You contributed support for set comments in PR #290 — could you take a look at this PR and confirm everything looks good please?

Copy link
Contributor

@turekt turekt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stapelberg stapelberg merged commit 4d2aea8 into google:main Jan 15, 2025
2 checks passed
@stapelberg
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants