Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
data_prep: only include c/cpp files as potential harnesses (#317)
A more precise approach is needed when searching for potential harnesses due to performance issues. For example, when analyzing `croaring` the following files all match the existing set up, but none of them have the potential of being the actual source code of a harness. ```sh /tmp/tmpjg7oqx4m/out/src/croaring/build-dir/CMakeFiles/CMakeScratch/TryCompile-9ReWwb/cmake_install.cmake /tmp/tmpjg7oqx4m/out/src/croaring/build-dir/CMakeFiles/CMakeScratch/TryCompile-9ReWwb/CMakeFiles/cmake.check_cache /tmp/tmpjg7oqx4m/out/src/croaring/build-dir/CMakeFiles/CMakeScratch/TryCompile-9ReWwb/CMakeFiles/CMakeDirectoryInformation.cmake /tmp/tmpjg7oqx4m/out/src/croaring/build-dir/CMakeFiles/CMakeScratch/TryCompile-9ReWwb/CMakeFiles/cmTC_bc5f1.dir/DependInfo.cmake /tmp/tmpjg7oqx4m/out/src/croaring/build-dir/CMakeFiles/CMakeScratch/TryCompile-9ReWwb/CMakeFiles/cmTC_bc5f1.dir/CMakeCXXCompilerABI.cpp.o.d /tmp/tmpjg7oqx4m/out/src/croaring/build-dir/CMakeFiles/CMakeScratch/TryCompile-9ReWwb/CMakeFiles/cmTC_bc5f1.dir/cmake_clean.cmake /tmp/tmpjg7oqx4m/out/src/croaring/build-dir/CMakeFiles/CMakeScratch/TryCompile-9ReWwb/CMakeFiles/cmTC_bc5f1.dir/CMakeCXXCompilerABI.cpp.o ``` For `croaring`, a total of 1200+ potential harnesses are identified with the current approach, and it takes a fairly long time (tens of minutes) to run through scanning for potential harnesess as a fair amount of the wrong files causes the 100sec timeout in `clang-format`. This PR makes the logic more precise to only include relevant source code files. For `croaring` it reduces to 65 potential harnesses (including the relevant harnesses) and it takes a couple of seconds to go through scanning for potential harnesses. --------- Signed-off-by: David Korczynski <[email protected]>
- Loading branch information