grass-addons: initial integration #12889
Conversation
|
Shivam7-1 is integrating a new project: |
|
Thanks @Shivam7-1 . |
|
Thanks, I've forwarded this to the panel. |
|
Hii @DonggeLiu Thanks For Forwarding is there Any Update on this? |
|
Hii @DonggeLiu is there Any Update on this? |
|
Hi @Shivam7-1, thanks for the reminder. Thanks : ) |
|
Hii @DonggeLiu Thanks For Reviewing |
projects/grass-addons/fuzz_target.c
Outdated
| @@ -0,0 +1,53 @@ | |||
| // Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
Given this is already merged in the project-under-test (which is also the way OSS-Fuzz prefers), shall we remove it here and update the build script?
There was a problem hiding this comment.
Hii @DonggeLiu
Thanks i think it not required now it can be mergable directly here also
If removing is better you can do it Thanks
There was a problem hiding this comment.
Hii @DonggeLiu Any merging Update on this
There was a problem hiding this comment.
Could you remove the fuzz target file?
Also, could you please address the CI failure, as @tyler92 kindly pointed out?
Thanks.
There was a problem hiding this comment.
Hii @DonggeLiu I had Updated Code accordingly and remove fuzz file from is it looks good now
Thanks
There was a problem hiding this comment.
Could you check the CI failures below and ensure they all pass?
There was a problem hiding this comment.
Yes as i check is the only reason with header change to 2024 to 2025?
Or any update required on build.sh file
Could you help review build.sh file if possible because i am integarting project first time
Thanms
There was a problem hiding this comment.
Did you see this in https://github.com/google/oss-fuzz/actions/runs/12921531205/job/36035725551?pr=12889?
clang++: error: no such file or directory: 'https://github.com/OSGeo/grass-addons/blob/grass8/Fuzz/fuzz_target.c'
ALL CI checks should pass before we can merge, thanks.
There was a problem hiding this comment.
But it was present here only https://github.com/OSGeo/grass-addons/blob/grass8/Fuzz/fuzz_target.c
There was a problem hiding this comment.
Hii @DonggeLiu Here i am geeting this error and i wont be able to the find the problem behind this Could you help in this
Thanks
projects/grass-addons/build.sh
Outdated
|
|
||
| mkdir build | ||
| cd build | ||
| cmake .. |
There was a problem hiding this comment.
It doesn't work, there is no CMakeLists.txt in the project 🙂
|
Hii @DonggeLiu is there Update on this if requires can you please tell me or update this |
|
Hii @DonggeLiu i had tried to run build.sh file but it still get failed in check Could you help here to get this build.sh run |
|
Hii @DonggeLiu some check still failing could you please help here to get this passed |
initial integration for grass-addons Project here is Approval from maintainer with linked PR OSGeo/grass-addons#1267
Updated @DonggeLiu
Thanks For Reviewing
Major Users of the Project:
The
grass-addonsproject is a part of the GRASS GIS (Geographic Resources Analysis Support System) software, which is widely used by geospatial professionals, researchers, and organizations around the world. Major users include environmental agencies, universities, and research institutions that rely on GRASS GIS for spatial data analysis, modeling, and visualization.Criticality of the Project:
The
grass-addonsrepository contains additional modules and scripts that extend the functionality of the core GRASS GIS software. These addons are critical for users who require specialized tools for their geospatial analysis tasks. Ensuring the security and reliability of these addons is vital as they are used in various scientific research projects and operational systems that depend on accurate and reliable geospatial data processing.I hope this information helps in evaluating