feat: expand Ubuntu ecosystem to include more variants #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
LGTM, though you might also need to update the API. This only allows the initial query to match successfully, but the API have additional checks within python to see if an affected field matches, and I'm not sure if that only checks version, or also checks ecosystem as well.
Good catch, I will fix the API part in a followup PR after I re-put test instance Ubuntu records |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #2963
OSV-Scanner mismatches Ubuntu vulnerabilities due to variations in ecosystem naming (e.g., :LTS, :Pro).
Adds a function to expand the Ubuntu ecosystem list with all possible variants, ensuring accurate vulnerability matching.
TODO: