Skip to content
This repository has been archived by the owner on Feb 5, 2025. It is now read-only.

Revert back to C++17 for now #1246

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Revert back to C++17 for now #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ build --copt=-Wno-error=deprecated-declarations
# isn't recognized on older SDKs
build --copt=-Wno-unknown-warning-option
build --copt=-Wno-error=deprecated-non-prototype
build --per_file_copt=.*\.mm\$@-std=c++20
build --cxxopt=-std=c++20
build --host_cxxopt=-std=c++20
build --per_file_copt=.*\.mm\$@-std=c++17
build --cxxopt=-std=c++17
build --host_cxxopt=-std=c++17

build --copt=-DSANTA_OPEN_SOURCE=1
build --cxxopt=-DSANTA_OPEN_SOURCE=1
Expand Down
5 changes: 3 additions & 2 deletions Source/common/SantaCacheTest.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

#import <XCTest/XCTest.h>

#include <compare>
#include <numeric>
#include <string>
#include <vector>
Expand Down Expand Up @@ -246,7 +245,9 @@ - (void)testCompareAndSwap {
uint64_t first_val;
uint64_t second_val;

auto operator<=>(const S &rhs) const = default;
bool operator==(const S &rhs) const {
return first_val == rhs.first_val && second_val == rhs.second_val;
}
};
template <>
uint64_t SantaCacheHasher<S>(S const &s) {
Expand Down