Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to create tarpc server on existing listener #411

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

SabatierBoris
Copy link
Contributor

When you want to use systemd.socket or systemfd for allocate the socket (TCP or UNIX) you need to be able to create a server on already existing listener

Copy link

google-cla bot commented Dec 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tikue
Copy link
Collaborator

tikue commented Dec 30, 2023

Thanks, and apologies for the review delay! Can you add unit tests for the new functions? Other than that, looks great.

@SabatierBoris
Copy link
Contributor Author

Thanks, and apologies for the review delay! Can you add unit tests for the new functions? Other than that, looks great.

Hi, no problem.

I add some tests based on existing TCP and UDS tests.

@tikue tikue merged commit d62706e into google:master Jan 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants