-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain class: SwapCurveBuilderResult #44
base: master
Are you sure you want to change the base?
Conversation
Remove definition of class attributes, which are already detailed in the docs: SwapCurveBuilderResult.md. Instead, explain the use of the class using a similar convention found under other Class headers in the docs.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@@ -37,7 +37,7 @@ Functions to handle rates. | |||
|
|||
## Classes | |||
|
|||
[`class SwapCurveBuilderResult`](../tf_quant_finance/rates/SwapCurveBuilderResult.md): SwapCurveBuilderResult(times, rates, discount_factors, initial_rates, converged, failed, iterations, objective_value) | |||
[`class SwapCurveBuilderResult`](../tf_quant_finance/rates/SwapCurveBuilderResult.md): Build curves for swapping future cash flows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs are auto-generated from the inline code documentation. So the right way to fix this would be to modify the docstring of class SwapCurveBuilderResult defined in swap_curve_common.py.
SwapCurveBuilderResult is a namedtuple so we need to add the docstring in a roundabout way. My suggestion would be to do:
SwapCurveBuilderResult.doc = """Results from a swap curve construction ..."""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix Johann.
Note that you will need to accept the CLA to merge the change.
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for a slow reply. Could you please resolve my comment and I patch this in?
@@ -37,7 +37,7 @@ Functions to handle rates. | |||
|
|||
## Classes | |||
|
|||
[`class SwapCurveBuilderResult`](../tf_quant_finance/rates/SwapCurveBuilderResult.md): SwapCurveBuilderResult(times, rates, discount_factors, initial_rates, converged, failed, iterations, objective_value) | |||
[`class SwapCurveBuilderResult`](../tf_quant_finance/rates/SwapCurveBuilderResult.md): Build curves for swapping future cash flows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
'Results from a swap curve construction.'
This is because actual curve fitting/building is done by swap_curve_fit method.
Instead of updating rates.md file, could you please navigate to SwapCurveBuilderResult and add
SwapCurveBuilderResult.doc = """Results from a swap curve construction."""
Remove definition of class attributes, which are already detailed in the docs: SwapCurveBuilderResult.md. Instead, explain the use of the class using a similar convention found under other Class headers in the docs.